linux-kernel - Re: [PATCH 1/6] arm64: dts: freescale: tqma9352: Add partitions subnode to spi-nor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 3 Jun 2024 09:12:18 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux@...tq-group.com,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: freescale: tqma9352: Add partitions
 subnode to spi-nor

On Tue, Apr 23, 2024 at 01:31:46PM +0200, Alexander Stein wrote:
> The bootloader adds MTD partitions in this subnode if present, or in the
> spi-nor node itself otherwise. Direct children cause warnings like:
> 425e0000.spi: ofpart partition /soc@...us@...00000/spi@...e0000/flash@0/
>   partition@...000 (/soc@...us@...00000/spi@...e0000/flash@0) #size-cells
>   is wrongly set to <0>, assuming <1> for parsing partitions.
> 
> This is due flexspi node having #size-cells = <0>. Setting #size-cells in
> MTD nodes itself is deprecated by mtd.yaml.
> Fix all this by adding an empty partitions node which the bootloader will
> fill with configured MTD partitions.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>

Applied all, thanks!