linux-kernel - Re: [PATCH] Fix filesystem issue: description of the fix Fix mark_buffer_dirty_inode to mark_buffer_dirty_fsync Signed-off-by: HyeonWoo Cha <chw1119@...yang.ac.kr>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 3 Jun 2024 08:35:51 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Hyeonwoo Cha <chw1119@...yang.ac.kr>
Cc: david.sterba@...e.com, aivazian.tigran@...il.com, brauner@...nel.org,
	jack@...e.cz, tytso@....edu, adilger.kernel@...ger.ca,
	hirofumi@...l.parknet.co.jp, sfr@...b.auug.org.au,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-ext4@...r.kernel.org, reiserfs-devel@...r.kernel.org
Subject: Re: [PATCH] Fix filesystem issue: description of the fix Fix
 mark_buffer_dirty_inode to mark_buffer_dirty_fsync Signed-off-by: HyeonWoo
 Cha <chw1119@...yang.ac.kr>

On Mon, Jun 03, 2024 at 03:59:10PM +0900, Hyeonwoo Cha wrote:

NAK.  Reasons:
	* patch described as a fix; that implies that some behaviour
change is there.  Yet there's no description of that change or
explanation of the problem being fixed.
	* lack of _any_ explanations, period.  Including e.g.
a discussion of the reasons why the change makes sense.
	* apparent blind trust in continued applicability of comments
that date back to 2002; in any case, no analysis is offered anywhere -
reviewers are supposed to do that themselves, presumably.
	* failure to Cc the original author of the comment in question.