[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACO55tuOQxQ=BuDj34SXGREE4numtRDFzJY4Qj_Fr0rrLj4ang@mail.gmail.com>
Date: Mon, 3 Jun 2024 09:50:29 +0200
From: Karol Herbst <kherbst@...hat.com>
To: Szőke Benjamin <egyszeregy@...email.hu>
Cc: bskeggs@...hat.com, lyude@...hat.com, airlied@...il.com, daniel@...ll.ch,
dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to nvkm_i2c_aux.c
and nvkm_i2c_aux.h
On Sun, Jun 2, 2024 at 1:01 AM Szőke Benjamin <egyszeregy@...email.hu> wrote:
>
> s=20181004; d=freemail.hu;
> h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding;
> l=8472; bh=iw0a2TUtlt0KIetu+spJR9WLW1F3MPSfBbxxiBBkhDM=;
> b=1oSo+wfGjIoAfhgzfBaxNDoTN0TmXW/jadL52HL5ZAyzWMk15XqSBLjBkAd//Bh9
> u1d+ypo+idz4sTys/CYP5oS8lb8fepRTYBFboPsOAnbHQg6tR0QizBnjyYGq1iMYD02
> GmZWamFVQ/I9kT0XMOMhoKNp1jmr3tFr0iaoS+PqyGv5aNFi6tmiFSJT5fnNaf8/Bct
> XgidaouR1QSqrB6vgHDUjd13+165V+RoCh/CflqZroE132r01M9mxZU5bk4M4uMO38l
> HwZjS8YTSOmTA49PcLYbh+hr+e+GVFHP+X1wgmd/93wqlySRgqM7N1fh84jucg03IMS
> D/tvbePTzg==
> Content-Transfer-Encoding: quoted-printable
>
> 2024. 06. 02. 0:12 keltez=C3=A9ssel, Karol Herbst =C3=ADrta:
> > On Sat, Jun 1, 2024 at 11:33=E2=80=AFPM <egyszeregy@...email.hu> wrote:
> >>
> >> s=3D20181004; d=3Dfreemail.hu;
> >> h=3DFrom:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-T=
> ype:Content-Transfer-Encoding;
> >> l=3D6462; bh=3DCnHSqkRX34kqCWN2/oPtvm9wm8HJCe8QhPwQypdpi3w=3D=
> ;
> >> b=3DJDlDB9yOQDBY7EDnRMrt8qYnWfH8J/LKYKb90434FH1tuOL04za+3TXXS=
> bU0uvs0
> >> hWYDYjpbob4XGgUcd1s+lCkerOgDwkpWJWKFW8N5j6WENAKdR/hWJgcma2JED=
> DotXZ0
> >> cisYRrLsQBfjyKkBWw0qv/5PDe7vliytix5oP2piBPJC+uR3pN8OKck/+zLBG=
> lJY4za
> >> qywwOiMNzHAdyOJT5kCg0yd+k186Oa1jX93iCpiRk5mxJQqJJcAxfW8rYbKRX=
> i5QQTl
> >> SymDGdZ72wK5PkHxGgpZ9qXZtFV3eH4+95xNzpoPowMkXFkBy1uMClZzxv1oB=
> mRo8o6
> >> CXPcfsWUsQ=3D=3D
> >> Content-Transfer-Encoding: quoted-printable
> >>
> >> From: Benjamin Sz=3DC5=3D91ke <egyszeregy@...email.hu>
> >>
> >> The goal is to clean-up Linux repository from AUX file names, because
> >> the use of such file names is prohibited on other operating systems
> >> such as Windows, so the Linux repository cannot be cloned and
> >> edited on them.
> >>
> >=20
> > something went horribly wrong with encoding so the patch is pretty much=
> invalid.
> >=20
> >> Signed-off-by: Benjamin Sz=3DC5=3D91ke <egyszeregy@...email.hu>
> >> ---
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/Kbuild | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgf119.c | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 2 =
> +-
> >> .../gpu/drm/nouveau/nvkm/subdev/i2c/{aux.c =3D3D> nvkm_i2c_aux.c} =
> | 2 +-
> >> .../gpu/drm/nouveau/nvkm/subdev/i2c/{aux.h =3D3D> nvkm_i2c_aux.h} =
> | 0
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padg94.c | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgf119.c | 2 =
> +-
> >> drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c | 2 =
> +-
> >> 11 files changed, 10 insertions(+), 10 deletions(-)
> >> rename drivers/gpu/drm/nouveau/nvkm/subdev/i2c/{aux.c =3D3D> nvkm_i2=
> c_aux.=3D
> >> c} (99%)
> >> rename drivers/gpu/drm/nouveau/nvkm/subdev/i2c/{aux.h =3D3D> nvkm_i2=
> c_aux.=3D
> >> h} (100%)
> >>
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/Kbuild b/drivers/=
> gpu=3D
> >> /drm/nouveau/nvkm/subdev/i2c/Kbuild
> >> index 819703913a00..c488dfce4392 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/Kbuild
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/Kbuild
> >> @@ -25,7 +25,7 @@ nvkm-y +=3D3D nvkm/subdev/i2c/busnv50.o
> >> nvkm-y +=3D3D nvkm/subdev/i2c/busgf119.o
> >> nvkm-y +=3D3D nvkm/subdev/i2c/bit.o
> >> =3D20
> >> -nvkm-y +=3D3D nvkm/subdev/i2c/aux.o
> >> +nvkm-y +=3D3D nvkm/subdev/i2c/nvkm_i2c_aux.o
> >> nvkm-y +=3D3D nvkm/subdev/i2c/auxg94.o
> >> nvkm-y +=3D3D nvkm/subdev/i2c/auxgf119.o
> >> nvkm-y +=3D3D nvkm/subdev/i2c/auxgm200.o
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c b/drive=
> rs/=3D
> >> gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c
> >> index dd391809fef7..30bf84e77db9 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c
> >> @@ -24,7 +24,7 @@
> >> #define anx9805_pad(p) container_of((p), struct anx9805_pad, base)
> >> #define anx9805_bus(p) container_of((p), struct anx9805_bus, base)
> >> #define anx9805_aux(p) container_of((p), struct anx9805_aux, base)
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> #include "bus.h"
> >> =3D20
> >> struct anx9805_pad {
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c b/driver=
> s/g=3D
> >> pu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
> >> index 47068f6f9c55..9e07ba444ca8 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
> >> @@ -22,7 +22,7 @@
> >> * Authors: Ben Skeggs <bskeggs@...hat.com>
> >> */
> >> #define g94_i2c_aux(p) container_of((p), struct g94_i2c_aux, base)
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> =3D20
> >> struct g94_i2c_aux {
> >> struct nvkm_i2c_aux base;
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgf119.c b/driv=
> ers=3D
> >> /gpu/drm/nouveau/nvkm/subdev/i2c/auxgf119.c
> >> index dab40cd8fe3a..8709b728c38b 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgf119.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgf119.c
> >> @@ -19,7 +19,7 @@
> >> * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE US=
> E OR
> >> * OTHER DEALINGS IN THE SOFTWARE.
> >> */
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> =3D20
> >> static const struct nvkm_i2c_aux_func
> >> gf119_i2c_aux =3D3D {
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c b/driv=
> ers=3D
> >> /gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c
> >> index 8bd1d442e465..f40c5709d217 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c
> >> @@ -22,7 +22,7 @@
> >> * Authors: Ben Skeggs <bskeggs@...hat.com>
> >> */
> >> #define gm200_i2c_aux(p) container_of((p), struct gm200_i2c_aux, bas=
> e)
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> =3D20
> >> struct gm200_i2c_aux {
> >> struct nvkm_i2c_aux base;
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c b/drivers/=
> gpu=3D
> >> /drm/nouveau/nvkm/subdev/i2c/base.c
> >> index 976539de4220..736275f0c774 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> >> @@ -22,7 +22,7 @@
> >> * Authors: Ben Skeggs
> >> */
> >> #include "priv.h"
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> #include "bus.h"
> >> #include "pad.h"
> >> =3D20
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c b/drivers/g=
> pu/=3D
> >> drm/nouveau/nvkm/subdev/i2c/nvkm_i2c_aux.c
> >> similarity index 99%
> >> rename from drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c
> >> rename to drivers/gpu/drm/nouveau/nvkm/subdev/i2c/nvkm_i2c_aux.c
> >> index d063d0dc13c5..6b76df02c63a 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/nvkm_i2c_aux.c
> >> @@ -24,7 +24,7 @@
> >> =3D20
> >> #include <linux/string_helpers.h>
> >> =3D20
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> #include "pad.h"
> >> =3D20
> >> static int
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.h b/drivers/g=
> pu/=3D
> >> drm/nouveau/nvkm/subdev/i2c/nvkm_i2c_aux.h
> >> similarity index 100%
> >> rename from drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.h
> >> rename to drivers/gpu/drm/nouveau/nvkm/subdev/i2c/nvkm_i2c_aux.h
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padg94.c b/driver=
> s/g=3D
> >> pu/drm/nouveau/nvkm/subdev/i2c/padg94.c
> >> index 5904bc5f2d2a..e9c55a57c878 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padg94.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padg94.c
> >> @@ -22,7 +22,7 @@
> >> * Authors: Ben Skeggs
> >> */
> >> #include "pad.h"
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> #include "bus.h"
> >> =3D20
> >> void
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgf119.c b/driv=
> ers=3D
> >> /gpu/drm/nouveau/nvkm/subdev/i2c/padgf119.c
> >> index 3bc4d0310076..1af64e25d838 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgf119.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgf119.c
> >> @@ -22,7 +22,7 @@
> >> * Authors: Ben Skeggs
> >> */
> >> #include "pad.h"
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> #include "bus.h"
> >> =3D20
> >> static const struct nvkm_i2c_pad_func
> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c b/driv=
> ers=3D
> >> /gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c
> >> index 7d417f6a816e..997a5a2146c4 100644
> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c
> >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c
> >> @@ -22,7 +22,7 @@
> >> * Authors: Ben Skeggs
> >> */
> >> #include "pad.h"
> >> -#include "aux.h"
> >> +#include "nvkm_i2c_aux.h"
> >> #include "bus.h"
> >> =3D20
> >> static void
> >> --=3D20
> >> 2.43.0
> >>
> >=20
>
> Hi,
>
> This patched is totally fine and visible in "linux-kernel@...r.kernel.org=
> " list=20
> page, so it should not be invalid. Please check your e-mail client SW and=
> fix=20
> your settings.
>
> https://lore.kernel.org/lkml/20240601212247.54786-1-egyszeregy@freemail.h=
> u/
> https://lore.kernel.org/lkml/20240601212247.54786-1-egyszeregy@freemail.h=
> u/raw
>
> kernel test robot used it for a build test successfully, so it has to be =
> a valid=20
> patch.
> https://github.com/intel-lab-lkp/linux/commits/egyszeregy-freemail-hu/drm=
> -nouveau-i2c-rename-aux-c-and-aux-h-to-nvkm_i2c_aux-c-and-nvkm_i2c_aux-h/=
> 20240602-053530
>
oh indeed. Looks like a client problem then. Sorry for the noise.
Powered by blists - more mailing lists