[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4p24kjtplk6bk7amhwsrvvtryeeblitnd46lhlapwqudykayzn@3ki4zl4oknua>
Date: Mon, 3 Jun 2024 11:28:47 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mark Brown <broonie@...nel.org>,
Yang Yingliang <yangyingliang@...wei.com>, Christophe JAILLET <christophe.jaillet@...adoo.fr>,
Thangaraj Samynathan <thangaraj.s@...rochip.com>, linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>,
NĂcolas F . R . A . Prado <nfraprado@...labora.com>, Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 2/8] spi: dw: Use new spi_xfer_is_dma_mapped() helper
On Fri, May 31, 2024 at 10:42:34PM +0300, Andy Shevchenko wrote:
> Replace a few lines of code by calling a spi_xfer_is_dma_mapped() helper.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Nice cleanup. Thanks!
Reviewed-by: Serge Semin <fancer.lancer@...il.com>
-Serge(y)
> ---
> drivers/spi/spi-dw-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
> index ddfdb903047a..431788dd848c 100644
> --- a/drivers/spi/spi-dw-core.c
> +++ b/drivers/spi/spi-dw-core.c
> @@ -19,6 +19,7 @@
> #include <linux/string.h>
> #include <linux/of.h>
>
> +#include "internals.h"
> #include "spi-dw.h"
>
> #ifdef CONFIG_DEBUG_FS
> @@ -438,8 +439,7 @@ static int dw_spi_transfer_one(struct spi_controller *host,
> transfer->effective_speed_hz = dws->current_freq;
>
> /* Check if current transfer is a DMA transaction */
> - if (host->can_dma && host->can_dma(host, spi, transfer))
> - dws->dma_mapped = host->cur_msg_mapped;
> + dws->dma_mapped = spi_xfer_is_dma_mapped(host, spi, transfer);
>
> /* For poll mode just disable all interrupts */
> dw_spi_mask_intr(dws, 0xff);
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
Powered by blists - more mailing lists