linux-kernel - Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 3 Jun 2024 09:31:45 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: <linux@...blig.org>
CC: <yangyicong@...ilicon.com>, <peterz@...radead.org>, <mingo@...hat.com>,
	<jolsa@...nel.org>, <irogers@...gle.com>, <linux-perf-users@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

On Sun,  2 Jun 2024 01:07:09 +0100
linux@...blig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
LGTM
Minimal
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
by which I mean I searched for it and indeed found only this definition.

> ---
>  tools/perf/util/hisi-ptt.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
>  	u32 pmu_type;
>  };
>  
> -struct hisi_ptt_queue {
> -	struct hisi_ptt *ptt;
> -	struct auxtrace_buffer *buffer;
> -};
> -
>  static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
>  {
>  	uint32_t head = *(uint32_t *)buf;