linux-kernel - Re: [PATCH] platform/x86: yt2-1380: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 3 Jun 2024 11:44:01 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Arnd Bergmann <arnd@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...db.de>, Armin Wolf <W_Armin@....de>,
 SungHwan Jung <onenowy@...il.com>,
 Henning Schild <henning.schild@...mens.com>, Ai Chao <aichao@...inos.cn>,
 Robert Joslyn <robert.joslyn@...rectangle.org>,
 Heiner Kallweit <hkallweit1@...il.com>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: yt2-1380: add CONFIG_EXTCON dependency

Hi,

On 5/28/24 1:59 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This driver uses the extcon subsystem and fails to build
> when it cannot call into that subsystem:
> 
> x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_worker':
> lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d819): undefined reference to `extcon_get_state'
> x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d853): undefined reference to `extcon_get_state'
> x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_serdev_probe':
> lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9da22): undefined reference to `extcon_get_extcon_dev'
> x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9dc0c): undefined reference to `devm_extcon_register_notifier_all'
> 
> Add a Kconfig dependency to make it it always builds correctly.
> 
> Fixes: b2ed33e8d486 ("platform/x86: Add lenovo-yoga-tab2-pro-1380-fastcharger driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans




> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 809888e4c1e7..9f850e4617bf 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -136,6 +136,7 @@ config YOGABOOK
>  config YT2_1380
>  	tristate "Lenovo Yoga Tablet 2 1380 fast charge driver"
>  	depends on SERIAL_DEV_BUS
> +	depends on EXTCON
>  	depends on ACPI
>  	help
>  	  Say Y here to enable support for the custom fast charging protocol