linux-kernel - Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl0jIZbIKV6mG12I@google.com>
Date: Mon, 3 Jun 2024 01:57:53 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Lee Jones <lee@...nel.org>, Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>, Pavel Machek <pavel@....cz>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Dustin Howett <dustin@...ett.net>,
	Mario Limonciello <mario.limonciello@....com>,
	linux-leds@...r.kernel.org,
	Rajas Paranjpe <paranjperajas@...il.com>
Subject: Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow
 binding through mfd device

On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Weißschuh wrote:
> The ChromeOS EC used in Framework laptops supports the standard CrOS EC
> keyboard backlight protocol.
> However the firmware on these laptops doesn't implement the ACPI ID
> GOOG0002 that is recognized by cros_kbd_led_backlight and they also
> don't use device tree.
> 
> Prepare the existing cros_kbd_led_backlight driver to be probed through
> the CrOS EC mfd device which works without ACPI or OF support.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

The patch overall looks good to me but it depends on previous patch in the
series (for LED_REJECT_NAME_CONFLICT).  Let's wait for review.