linux-kernel - Re: [PATCH] readdir: Remove unused header include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240603110652.5hjcsajjjmefv63i@quack3>
Date: Mon, 3 Jun 2024 13:06:52 +0200
From: Jan Kara <jack@...e.cz>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] readdir: Remove unused header include

On Sun 02-06-24 12:15:35, Thorsten Blum wrote:
> Since commit c512c6918719 ("uaccess: implement a proper
> unsafe_copy_to_user() and switch filldir over to it") the header file is
> no longer needed.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/readdir.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 5045e32f1cb6..d6c82421902a 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -22,8 +22,6 @@
>  #include <linux/compat.h>
>  #include <linux/uaccess.h>
>  
> -#include <asm/unaligned.h>
> -
>  /*
>   * Some filesystems were never converted to '->iterate_shared()'
>   * and their directory iterators want the inode lock held for
> -- 
> 2.45.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR