linux-kernel - Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240603111844.l4g2yk5q6z23cz3n@quack3>
Date: Mon, 3 Jun 2024 13:18:44 +0200
From: Jan Kara <jack@...e.cz>
To: Youling Tang <youling.tang@...ux.dev>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include

On Mon 03-06-24 09:48:34, Youling Tang wrote:
> From: Youling Tang <tangyouling@...inos.cn>
> 
> After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
> in this file needs anything from `linux/prefetch.h`.
> 
> Signed-off-by: Youling Tang <tangyouling@...inos.cn>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/direct-io.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index b0aafe640fa4..bbd05f1a2145 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -37,7 +37,6 @@
>  #include <linux/rwsem.h>
>  #include <linux/uio.h>
>  #include <linux/atomic.h>
> -#include <linux/prefetch.h>
>  
>  #include "internal.h"
>  
> @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
>  	struct blk_plug plug;
>  	unsigned long align = offset | iov_iter_alignment(iter);
>  
> -	/*
> -	 * Avoid references to bdev if not absolutely needed to give
> -	 * the early prefetch in the caller enough time.
> -	 */
> -
>  	/* watch out for a 0 len io from a tricksy fs */
>  	if (iov_iter_rw(iter) == READ && !count)
>  		return 0;
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR