linux-kernel - RE: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR11MB5995E948FEC165CC5A27488193FF2@DM4PR11MB5995.namprd11.prod.outlook.com>
Date: Mon, 3 Jun 2024 03:10:30 +0000
From: "Zhang, Lixu" <lixu.zhang@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Srinivas Pandruvada
	<srinivas.pandruvada@...ux.intel.com>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion

>-----Original Message-----
>From: Arnd Bergmann <arnd@...nel.org>
>Sent: Saturday, June 1, 2024 12:28 AM
>To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>; Jiri Kosina
><jikos@...nel.org>; Benjamin Tissoires <bentiss@...nel.org>; Zhang, Lixu
><lixu.zhang@...el.com>
>Cc: Arnd Bergmann <arnd@...db.de>; linux-input@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Subject: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
>
>@@ -228,23 +233,24 @@ void ishtp_loader_work(struct work_struct *work)
> 		return;
> 	}
>
>-	fragment->fragment.header.command =
>LOADER_CMD_XFER_FRAGMENT;
>-	fragment->fragment.xfer_mode = LOADER_XFER_MODE_DMA;
>-	fragment->fragment.is_last = 1;
>-	fragment->fragment.size = ish_fw->size;
>+	fragment->fragment.header = cpu_to_le32(fragment_hdr.val32);;
s/;;/;/

>+	fragment->fragment.xfer_mode =
>cpu_to_le32(LOADER_XFER_MODE_DMA);
>+	fragment->fragment.is_last = cpu_to_le32(1);
>+	fragment->fragment.size = cpu_to_le32(ish_fw->size);
> 	/* Calculate the size of a single DMA fragment */
> 	fragment_size = PFN_ALIGN(DIV_ROUND_UP(ish_fw->size,