linux-kernel - Re: [PATCH] mm: pass the pfn to set_pageblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bb60f7db3a11e86e6f48c1eefe7f27d7d23019c@linux.dev>
Date: Mon, 03 Jun 2024 13:48:50 +0000
From: "Yajun Deng" <yajun.deng@...ux.dev>
To: "Matthew Wilcox" <willy@...radead.org>
Cc: akpm@...ux-foundation.org, rppt@...nel.org, hannes@...xchg.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: pass the pfn to set_pageblock_migratetype

June 3, 2024 at 9:03 PM, "Matthew Wilcox" <willy@...radead.org> wrote:



> 
> On Mon, Jun 03, 2024 at 08:41:00PM +0800, Yajun Deng wrote:
> 
> > 
> > It is necessary to calculate the pfn in the set_pageblock_migratetype(),
> > 
> >  but most of the callers already have the pfn.
> > 
> >  
> > 
> >  To reduce the calculation, pass the pfn to set_pageblock_migratetype().
> > 
> 
> It's not exactly a hard computation though. Have you done any
> 
> measurements that show this patch is an improvement?
>

No, just view the code. But some callers are in a for loop.