linux-kernel - Re: [PATCH RFT v3 3/4] hwmon: (spd5118) Add suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <caa69460-f515-4b61-9289-4169fa14396f@roeck-us.net>
Date: Mon, 3 Jun 2024 06:50:28 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Stephen Horvath <s.horvath@...look.com.au>, linux-hwmon@...r.kernel.org
Cc: devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 Armin Wolf <W_Armin@....de>, Thomas Weißschuh
 <linux@...ssschuh.net>, René Rebe <rene@...ctcode.de>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH RFT v3 3/4] hwmon: (spd5118) Add suspend/resume support

On 6/3/24 05:31, Stephen Horvath wrote:
> Hi,
> 
> On 1/6/24 09:05, Guenter Roeck wrote:
>> Add suspend/resume support to ensure that limit and configuration
>> registers are updated and synchronized after a suspend/resume cycle.
>>
>> Cc: Armin Wolf <W_Armin@....de>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>> v3: No change
>>
>> v2: New patch
>>
>> RFT: I tested the patch through a suspend/resume cycle, and it seems
>>       to work, but I am not sure if that had any effect because,
>>       after all, the memory is still active during suspend/resume.
>>       I was unable to test a hibernation cycle with my system.
>>
> 
> For me, the driver just reports 0°C after suspend/resume, but works fine beforehand, tested on both my desktop and laptop, with kernel 6.9.3 and 6.10.0-rc2 (on the laptop only).
> 
> Hibernation does seem to work fine though (at least on 6.9.3).
> 

Thanks a lot for the report. I can confirm that this happens if the enable
attribute was not touched before the suspend/resume cycle. I'll send another
version with the fix.

Guenter