linux-kernel - Re: [PATCH v2 2/3] coresight: Add support to get preferred id for system trace sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 3 Jun 2024 23:15:32 +0800
From: kernel test robot <lkp@...el.com>
To: Mao Jinlong <quic_jinlmao@...cinc.com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Mike Leach <mike.leach@...aro.org>,
	James Clark <james.clark@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, coresight@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Tingwei Zhang <quic_tingweiz@...cinc.com>,
	Yuanfang Zhang <quic_yuanfang@...cinc.com>,
	Tao Zhang <quic_taozha@...cinc.com>,
	songchai <quic_songchai@...cinc.com>
Subject: Re: [PATCH v2 2/3] coresight: Add support to get preferred id for
 system trace sources

Hi Mao,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on atorgue-stm32/stm32-next linus/master v6.10-rc2 next-20240603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mao-Jinlong/dt-bindings-arm-Add-trace-id-for-coresight-dummy-source/20240603-175023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240603094354.2348-3-quic_jinlmao%40quicinc.com
patch subject: [PATCH v2 2/3] coresight: Add support to get preferred id for system trace sources
config: arm-randconfig-001-20240603 (https://download.01.org/0day-ci/archive/20240603/202406032259.9poyd8Ts-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240603/202406032259.9poyd8Ts-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406032259.9poyd8Ts-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/hwtracing/coresight/coresight-platform.c:797:12: error: redefinition of 'of_coresight_get_trace_id'
     797 | static int of_coresight_get_trace_id(struct device *dev, u32 *id)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/hwtracing/coresight/coresight-platform.c:191:12: note: previous definition of 'of_coresight_get_trace_id' with type 'int(struct device *, u32 *)' {aka 'int(struct device *, unsigned int *)'}
     191 | static int of_coresight_get_trace_id(struct device *dev, u32 *id)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/hwtracing/coresight/coresight-platform.c:191:12: warning: 'of_coresight_get_trace_id' defined but not used [-Wunused-function]
--
   drivers/hwtracing/coresight/coresight-tpda.c: In function 'tpda_init_default_data':
>> drivers/hwtracing/coresight/coresight-tpda.c:254:16: error: too few arguments to function 'coresight_trace_id_get_system_id'
     254 |         atid = coresight_trace_id_get_system_id();
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/hwtracing/coresight/coresight-tpda.c:20:
   drivers/hwtracing/coresight/coresight-trace-id.h:126:5: note: declared here
     126 | int coresight_trace_id_get_system_id(int id);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/of_coresight_get_trace_id +797 drivers/hwtracing/coresight/coresight-platform.c

   796	
 > 797	static int of_coresight_get_trace_id(struct device *dev, u32 *id)
   798	{
   799		return -ENODEV;
   800	}
   801	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki