linux-kernel - Re: [PATCH] perf genelf: remove unused struct 'options'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUbtFd2V=cjSHd-KgFmrGQnncS5p7FXTNpL5kA+19qRNA@mail.gmail.com>
Date: Mon, 3 Jun 2024 09:32:47 -0700
From: Ian Rogers <irogers@...gle.com>
To: linux@...blig.org
Cc: peterz@...radead.org, mingo@...hat.com, jolsa@...nel.org, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf genelf: remove unused struct 'options'

On Sat, Jun 1, 2024 at 5:05 PM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@...gle.com>

Ian

> ---
>  tools/perf/util/genelf.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index ac17a3cb59dc..c8f6bee1fa61 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -54,11 +54,6 @@ typedef struct {
>    char         name[0]; /* Start of the name+desc data */
>  } Elf_Note;
>
> -struct options {
> -       char *output;
> -       int fd;
> -};
> -
>  static char shd_string_table[] = {
>         0,
>         '.', 't', 'e', 'x', 't', 0,                     /*  1 */
> --
> 2.45.1
>