linux-kernel - Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update global.turbo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3526e7a0e80ec1a3a011259c38ab4b772040ea4.camel@linux.intel.com>
Date: Mon, 03 Jun 2024 10:11:02 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Xi Ruoyao <xry111@...111.site>, "Rafael J. Wysocki" <rjw@...ysocki.net>,
  Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update
 global.turbo_disabled after initialization

On Mon, 2024-06-03 at 21:12 +0800, Xi Ruoyao wrote:
> On Sun, 2024-06-02 at 16:11 -0700, srinivas pandruvada wrote:
> 
> /* snip */
> 
> > What is the output of:
> > grep . /sys/devices/system/cpu/intel_pstate/*
> > 
> > Also 
> > rdmsr 0x771
> > rdmsr 0x774
> > 
> > 
> > Try these three patches. Don't worry about the commit description
> > for
> > this issue.
> 
> Unfortunately they still do not fix the issue for me.
> 
> The outputs of grep and rdmsr commands are initially:
> 
> /sys/devices/system/cpu/intel_pstate/hwp_dynamic_boost:0
> /sys/devices/system/cpu/intel_pstate/max_perf_pct:100
> /sys/devices/system/cpu/intel_pstate/min_perf_pct:9
> /sys/devices/system/cpu/intel_pstate/no_turbo:1
> /sys/devices/system/cpu/intel_pstate/num_pstates:41
> /sys/devices/system/cpu/intel_pstate/status:active
> /sys/devices/system/cpu/intel_pstate/turbo_pct:33
> rdmsr 0x771: 10d1f2c
> rdmsr 0x774: 1f04
> 
> But it then changes to:
> 
> /sys/devices/system/cpu/intel_pstate/hwp_dynamic_boost:0
> /sys/devices/system/cpu/intel_pstate/max_perf_pct:100
> /sys/devices/system/cpu/intel_pstate/min_perf_pct:9
> /sys/devices/system/cpu/intel_pstate/no_turbo:1
> /sys/devices/system/cpu/intel_pstate/num_pstates:41
> /sys/devices/system/cpu/intel_pstate/status:active
> /sys/devices/system/cpu/intel_pstate/turbo_pct:33
> rdmsr 0x771: 10c1f2c
> rdmsr 0x774: 1f04
> 
> It seems only the output of rdmsr 0x771 has changed.  And if I read
> the
> SDM correctly it's a "Most_Efficient_Performance" change.
That is fine.

We don't have any notifications either via ACPI or via HWP interrupt.
I think it was working by chance before this change as by the cpufreq
core is trying to set policy, the turbo is enabled by the firmware.

What is this laptop make and model?

Thanks,
Srinivas

> 
> > Please send me full dmesg after you see the issue.
> 
> Attached.  
>