linux-kernel - Re: [PATCH] ASoC: qcom: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 16:00:51 +0100
From: Mark Brown <broonie@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jeff Johnson <quic_jjohnson@...cinc.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Banajit Goswami <bgoswami@...cinc.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	kernel@...cinc.com
Subject: Re: [PATCH] ASoC: qcom: add missing MODULE_DESCRIPTION() macro

On Tue, Jun 04, 2024 at 05:46:14PM +0300, Dan Carpenter wrote:
> On Tue, Jun 04, 2024 at 12:56:09PM +0100, Mark Brown wrote:

> > Is anyone getting any value from these MODULE_DESCRIPTION()s?  This all
> > just seems like a huge amount of noise and I'm having trouble thinking
> > of a use case.

> The missing MODULE_DESCRIPTION() warnings are very annoying.  We
> recently missed a link error issue because the warning was drowned out
> in MODULE_DESCRIPTION() warnings.
> https://lore.kernel.org/all/202405182038.ncf1mL7Z-lkp@intel.com/

Yeah, adding the warning seems premature without having first added the
descriptions and I'm not clear in what situation anyone would actually
care given how rare it is for someone to manually interact with module
loading.  The number of cases where anyone would not just look at the
source seems vanishingly small.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)