linux-kernel - Re: [PATCH 3/3] kconfig: remove wrong expr_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 11:08:37 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] kconfig: remove wrong expr_trans_bool()

On Tue, Jun 4, 2024 at 1:19 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> expr_trans_bool() performs an incorrect transformation.
>
> [Test Code]
>
>     config MODULES
>             def_bool y
>             modules
>
>     config A
>             def_bool y
>             select C if B != n
>
>     config B
>             def_tristate m
>
>     config C
>             tristate
>
> [Result]
>
>     CONFIG_MODULES=y
>     CONFIG_A=y
>     CONFIG_B=m
>     CONFIG_C=m
>
> This result is incorrect because CONFIG_C=y is expected.
>
> Documentation/kbuild/kconfig-language.rst clearly explains the function
> of the '!=' operator:
>
>   (3) If the values of both symbols are equal, it returns 'n',
>       otherwise 'y'.
>
> Therefore, the statement:
>
>     select C if A != n

This is wrong.

I meant this:


      select C if B != n






-- 
Best Regards
Masahiro Yamada