linux-kernel - Re: [PATCH] Documentation/accel/qaic: Fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 09:36:45 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Danish Prakash <contact@...ishpraka.sh>
CC: Shuah Khan <skhan@...uxfoundation.org>,
        Carl Vanderlip
	<quic_carlv@...cinc.com>,
        Pranjal Ramajor Asha Kanojiya
	<quic_pkanojiy@...cinc.com>,
        Oded Gabbay <ogabbay@...nel.org>, "Jonathan
 Corbet" <corbet@....net>,
        "open list:QUALCOMM CLOUD AI (QAIC) DRIVER"
	<linux-arm-msm@...r.kernel.org>,
        "open list:QUALCOMM CLOUD AI (QAIC) DRIVER"
	<dri-devel@...ts.freedesktop.org>,
        "open list:DOCUMENTATION"
	<linux-doc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation/accel/qaic: Fix typo

For future reference, since this is the second revision of this change, 
the subject should have "[PATCH v2]".

On 6/1/2024 8:51 AM, Danish Prakash wrote:
> Fixed a typo in the docs where 'phsyical' > was corrected to 'physical'.

Commit text should be in the present simple tense.  You currently are 
using past tense here.  "Fixed" -> "Fix", etc.

> Signed-off-by: Danish Prakash <contact@...ishpraka.sh>
> ---

Since this is a single change and not a series, you should have a change 
log here which identifies what is different in this revision.

>   Documentation/accel/qaic/qaic.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
> index efb7771273bb..628bf2f7a416 100644
> --- a/Documentation/accel/qaic/qaic.rst
> +++ b/Documentation/accel/qaic/qaic.rst
> @@ -93,7 +93,7 @@ commands (does not impact QAIC).
>   uAPI
>   ====
>   
> -QAIC creates an accel device per phsyical PCIe device. This accel device exists
> +QAIC creates an accel device per physical PCIe device. This accel device exists
>   for as long as the PCIe device is known to Linux.
>   
>   The PCIe device may not be in the state to accept requests from userspace at