linux-kernel - Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl9PuZUMU_9bUfxQ@gallifrey>
Date: Tue, 4 Jun 2024 17:32:41 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Simon Horman <horms@...nel.org>
Cc: allison.henderson@...cle.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

* Simon Horman (horms@...nel.org) wrote:
> On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@...blig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> 
> nit: Maybe commit lines are best not line-wrapped.
>      I'm unsure.

Yeh I wasn't too sure, checkpatch seems to have code
to deal with it, so it is expecting it could be wrapped:

  # A commit match can span multiple lines so this block attempts to find a
  # complete typical commit on a maximum of 3 lines

> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> 
> The above not withstanding, this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Thanks!

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/