linux-kernel - Re: [PATCH] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ed9c5yp1.ffs@tglx>
Date: Tue, 04 Jun 2024 20:51:06 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>, linux-kernel@...r.kernel.org
Cc: Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] linux/interrupt.h: allow "guard" notation to disable
 and reenable IRQ

On Thu, May 30 2024 at 11:07, Dmitry Torokhov wrote:
> Drivers often need to first disable an interrupt, carry out some
> action, and then reenable the interrupt. Introduce support for the
> "guard" notation for this so that the following is possible:
>
> 	...
>
> 	scoped_cond_guard(mutex_intr, return -EINTR, &data->sysfs_mutex) {
> 		guard(disable_irq)(&client->irq);
>
> 		error = elan_acquire_baseline(data);
> 		if (error)
> 			return error;
> 	}
>
> 	...
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

I assume you want to carry this through the input tree, so you can
modify the drivers.

If so:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>