linux-kernel - Re: [PATCH v1 06/14] mm: memcg: move legacy memcg event code into memcontrol-v1.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl6Qt0F8-_66fBQ5@P9FQF9L96D>
Date: Mon, 3 Jun 2024 20:57:43 -0700
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Muchun Song <muchun.song@...ux.dev>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...nel.org>,
	Matthew Wilcox <willy@...radead.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 06/14] mm: memcg: move legacy memcg event code into
 memcontrol-v1.c

On Fri, May 31, 2024 at 11:33:46PM -0700, Shakeel Butt wrote:
> On Tue, May 28, 2024 at 01:20:58PM GMT, Roman Gushchin wrote:
> > Cgroup v1's memory controller contains a pretty complicated
> > event notifications mechanism which is not used on cgroup v2.
> > Let's move the corresponding code into memcontrol-v1.c.
> > 
> > Please, note, that mem_cgroup_event_ratelimit() remains in
> > memcontrol.c, otherwise it would require exporting too many
> > details on memcg stats outside of memcontrol.c.
> 
> In the followup work, we should decouple v1 only fields from v2 fields
> and then we should be able to move mem_cgroup_event_ratelimit() to the
> memcontrol-v1.c file.

Right, agree, this is my plan. In the RFC version I had a lot of #ifdef's
in mm/memcontrol.c and now I plan to do it in a nicer way, moving
cgroup v1 - specific stuff into separate functions.

Thanks!