linux-kernel - Re: [PATCH 05/18] maple_tree: set store type in mas_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 15:27:28 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc: linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org,
        linux-mm@...ck.org, akpm@...ux-foundation.org,
        zhangpeng.00@...edance.com, willy@...radead.org
Subject: Re: [PATCH 05/18] maple_tree: set store type in mas_store_prealloc()

* Sidhartha Kumar <sidhartha.kumar@...cle.com> [240604 13:42]:
> Set the store type in mas_store_prealloc(). This is needed as
> mas_wr_store_entry() will be modified to read the store type to make a
> decision about how to complete the store.

You have two of these small patches, one has a different description
"set write store type" vs "set store type".  I think they both can be
combined into the mas_wr_store_entry() modification?  They are pretty
straight forward and the commit log can explain them.

> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
> ---
>  lib/maple_tree.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b37fa8690558..3780d4bb0415 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5631,7 +5631,8 @@ void mas_store_prealloc(struct ma_state *mas, void *entry)
>  {
>  	MA_WR_STATE(wr_mas, mas, entry);
>  
> -	mas_wr_store_setup(&wr_mas);
> +	mas_wr_prealloc_setup(&wr_mas);
> +	mas_wr_store_type(&wr_mas);
>  	trace_ma_write(__func__, mas, 0, entry);
>  	mas_wr_store_entry(&wr_mas);
>  	MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas));
> -- 
> 2.45.1
>