linux-kernel - Re: auxdisplay: ht16k33: Drop device node reference after registration failure in ht16k33_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zl9rPy3hD-Hk-gxm@smile.fi.intel.com>
Date: Tue, 4 Jun 2024 22:30:07 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: kernel-janitors@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Marek Behún <kabel@...nel.org>,
	Miguel Ojeda <ojeda@...nel.org>,
	Robin van der Gracht <robin@...tonic.nl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: auxdisplay: ht16k33: Drop device node reference after
 registration failure in ht16k33_led_probe()

On Tue, Jun 04, 2024 at 08:15:35PM +0200, Markus Elfring wrote:
> > But, by design we don't use reference counting after we registered LED,
> > hence both error and successful paths need to have this,
> 
> Do you indicate really special data processing constraints here?

Nothing special, either we hold reference for the entire life time of the
device or not. For LEDS the convention is not to hold.


> > so add another fwnode_handle_put() after this branch.
> 
> Will this suggestion trigger any further clarifications for the affected software?

You need to put an fwnode handle in both paths: inside the if branch as you
have done (error path) and missing one is after that needs to be added.

Just address my comments and I believe everyone will be happy about it.

-- 
With Best Regards,
Andy Shevchenko