linux-kernel - Re: [PATCH net] net: wwan: iosm: Fix tainted pointer delete is case of region creation fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cff64803-3eaf-432b-9217-67c8fa8cdc77@gmail.com>
Date: Tue, 4 Jun 2024 22:39:09 +0300
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Aleksandr Mishin <amishin@...rgos.ru>,
 M Chetan Kumar <m.chetan.kumar@...el.com>
Cc: Loic Poulain <loic.poulain@...aro.org>,
 Johannes Berg <johannes@...solutions.net>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH net] net: wwan: iosm: Fix tainted pointer delete is case
 of region creation fail

On 04.06.2024 11:25, Aleksandr Mishin wrote:
> In case of region creation fail in ipc_devlink_create_region(), previously
> created regions delete process starts from tainted pointer which actually
> holds error code value.
> Fix this bug by decreasing region index before delete.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 4dcd183fbd67 ("net: wwan: iosm: devlink registration")
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>

Nice catch!

Acked-by: Sergey Ryazanov <ryazanov.s.a@...il.com>