linux-kernel - Re: [PATCH v2] dt-bindings: dma: fsl,imx-dma: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240604195741.GA1281512-robh@kernel.org>
Date: Tue, 4 Jun 2024 14:57:41 -0500
From: Rob Herring <robh@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Vinod Koul <vkoul@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, dmaengine@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: dma: fsl,imx-dma: Convert to dtschema

On Fri, May 31, 2024 at 04:43:52PM +0530, Animesh Agarwal wrote:
> On Fri, May 31, 2024 at 3:49 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > On 31/05/2024 11:04, Animesh Agarwal wrote:
> > > +  "#dma-cells":
> > > +    const: 1
> > > +
> > > +  dma-channels:
> > > +    maximum: 16
> >
> > maximum or const?
> 
> The txt binding says it should always be 16. Datasheet says this
> device has 16 channels of DMA services. I thought specifying just the
> maximum implies maximum=minimum=16. Sorry for missing the changelog in
> this version it was cost in the v1 of this patch.
> 
> >
> > deprecated: true
> >
> 
> Shall it not be
> "#dma-channels ":
>   deprecated: true
> ?

Yes. dma-channels is not deprecated.

For the old ones, maybe it has been long enough that their use has been 
dropped that you can just drop them in the conversion. Looks like there 
is no driver support already.

Rob