linux-kernel - Re: [PATCH] [v2] arm64/io: add constant-argument check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 04 Jun 2024 22:44:06 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jason Gunthorpe" <jgg@...pe.ca>, "Will Deacon" <will@...nel.org>
Cc: "Arnd Bergmann" <arnd@...nel.org>,
 "Catalin Marinas" <catalin.marinas@....com>, "Baoquan He" <bhe@...hat.com>,
 "Kefeng Wang" <wangkefeng.wang@...wei.com>,
 "Peter Zijlstra" <peterz@...radead.org>,
 "Mark Rutland" <mark.rutland@....com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] arm64/io: add constant-argument check

On Tue, Jun 4, 2024, at 22:12, Jason Gunthorpe wrote:
> On Tue, Jun 04, 2024 at 04:55:37PM +0100, Will Deacon wrote:
>> On Tue, May 28, 2024 at 05:37:11PM +0200, Arnd Bergmann wrote:
>> 
>> I think this is superseded by Mark's diff in reply to v1, right?
>> 
>> https://lore.kernel.org/r/ZlcODqVXTDh6n0h-@J2N7QTR9R3
>>
>> If so, Mark, please can you post that as a proper patch so that we can
>> get this fixed?
>
> I wouldn't say superseded, but I agree with Mark that we should have
> the __always_inline added to the __iowrite64_copy() and
> __const_memcpy_toio_aligned64() in addition to the stuff here.
>
> When I originally wrote this I copied the fairly common pattern of
> having the builtin_constant_p test inside a macro, but I see now it is
> quite common to put that into an inline. Putting it in the inline is
> definately much better, so I like Arnd's patch.
>
> Arnd can you just make that addition and repost this?
>

Yes, sorry for failing to follow up earlier. I'm doing a little
more build testing now, will send soon.

   Arnd