linux-kernel - Re: [net-next PATCH v5 2/7] net: ravb: Align poll function with NAPI docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4958f946-3c95-9280-9da8-3670a3187cc5@omp.ru>
Date: Tue, 4 Jun 2024 23:47:26 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Paul Barker <paul.barker.ct@...renesas.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	Simon Horman <horms@...nel.org>
CC: Biju Das <biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@...esas.com>, <netdev@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH v5 2/7] net: ravb: Align poll function with NAPI
 docs

On 6/4/24 10:28 AM, Paul Barker wrote:

> Align ravb_poll() with the documentation in
> `Documentation/networking/kapi.rst` and
> `Documentation/networking/napi.rst`.
> 
> The documentation says that we should prefer napi_complete_done() over
> napi_complete(), and using the former allows us to properly support busy
> polling. We should ensure that napi_complete_done() is only called if
> the work budget has not been exhausted, and we should only re-arm
> interrupts if it returns true.
> 
> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>

[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey