linux-kernel - Re: [PATCH] extcon: realtek: Use scope-based resource management in extcon_rtk_type_c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl-DBkt8sNb9xypq@smile.fi.intel.com>
Date: Wed, 5 Jun 2024 00:11:34 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: kernel-janitors@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Stanley Chang <stanley_chang@...ltek.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] extcon: realtek: Use scope-based resource management in
 extcon_rtk_type_c_init()

On Tue, Jun 04, 2024 at 10:06:14PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 4 Jun 2024 21:55:08 +0200
> 
> Scope-based resource management became supported also for another
> programming interface by contributions of Jonathan Cameron on 2024-02-17.
> See also the commit 59ed5e2d505bf5f9b4af64d0021cd0c96aec1f7c ("device
> property: Add cleanup.h based fwnode_handle_put() scope based cleanup.").
> 
> * Thus use the attribute “__free(fwnode_handle)”.
> 
> * Reduce the scope for the local variable “fwnode”.

> Fixes: 8a590d7371f0 ("extcon: add Realtek DHC RTD SoC Type-C driver")

The problem here is that the above mentioned API only recently appeared in the
kernel. It will be impossible to backport without backporting a new API, which
is usually contradicts the idea of stable kernels. That's why it's better to
really fix without using a new APIs and then convert to a new one. Hence needs
two patches.

-- 
With Best Regards,
Andy Shevchenko