linux-kernel - Re: [PATCH v2] crypto: ccp - Fix null pointer dereference in __sev_snp_shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 16:36:49 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Kim Phillips <kim.phillips@....com>, Ashish Kalra <ashish.kalra@....com>,
 John Allen <john.allen@....com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>
Cc: Mario Limonciello <mario.limonciello@....com>,
 linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Liam Merwick <liam.merwick@...cle.com>
Subject: Re: [PATCH v2] crypto: ccp - Fix null pointer dereference in
 __sev_snp_shutdown_locked

On 6/4/24 12:47, Kim Phillips wrote:
> Fix a null pointer dereference induced by DEBUG_TEST_DRIVER_REMOVE.
> Return from __sev_snp_shutdown_locked() if the psp_device or the
> sev_device structs are not initialized. Without the fix, the driver will
> produce the following splat:
> 

> 
> Fixes: 1ca5614b84ee ("crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP")
> Cc: stable@...r.kernel.org
> Signed-off-by: Kim Phillips <kim.phillips@....com>
> Reviewed-by: Liam Merwick <liam.merwick@...cle.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> Reviewed-by: John Allen <john.allen@....com>

Reviewed-by: Tom Lendacky <thomas.lendacky@....com>

> ---
> v2:
>   - Correct the Fixes tag (Tom L.)
>   - Remove log timestamps, elaborate commit text (John Allen)
>   - Add Reviews-by.
> 
> v1:
>   - https://lore.kernel.org/linux-crypto/20240603151212.18342-1-kim.phillips@amd.com/
> 
>   drivers/crypto/ccp/sev-dev.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>