linux-kernel - Re: [PATCH] resource: add a basic test for walk_iomem_res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zl-LFtGP3z4rR-7S@smile.fi.intel.com>
Date: Wed, 5 Jun 2024 00:45:58 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Chia-I Wu <olvaffe@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Baoquan He <bhe@...hat.com>,
	Alison Schofield <alison.schofield@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] resource: add a basic test for walk_iomem_res_desc

On Wed, Jun 05, 2024 at 12:38:27AM +0300, Andy Shevchenko wrote:
> On Tue, Jun 04, 2024 at 02:31:46PM -0700, Chia-I Wu wrote:

...

> > +	res[2] = (struct resource){
> > +		.start = offset,
> > +		.end = offset + SZ_1K - 1,
> > +		.name = "NESTED",
> > +	};
> 
> We have respective macros. Use them.

And use explicitly hardocded start in all of them instead of coding += for
offset variable. For the test cases is better when data is hardcoded, esp.
when it's an expected result (just to mention, here it seems an input data).

-- 
With Best Regards,
Andy Shevchenko