linux-kernel - Re: [PATCH net] net/mlx5: Fix tainted pointer delete is case of flow rules creation fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b09c707-208c-43ea-870a-1c637ca8ed53@intel.com>
Date: Tue, 4 Jun 2024 14:58:22 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Aleksandr Mishin <amishin@...rgos.ru>, Mark Bloch <mbloch@...dia.com>
CC: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Maor Gottlieb <maorg@...dia.com>, Shay Drory
	<shayd@...dia.com>, Jianbo Liu <jianbol@...dia.com>, Jinjie Ruan
	<ruanjinjie@...wei.com>, <netdev@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] net/mlx5: Fix tainted pointer delete is case of flow
 rules creation fail



On 6/4/2024 3:05 AM, Aleksandr Mishin wrote:
> In case of flow rule creation fail in mlx5_lag_create_port_sel_table(),
> instead of previously created rules, the tainted pointer is deleted
> deveral times.
> Fix this bug by using correct flow rules pointers.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 352899f384d4 ("net/mlx5: Lag, use buckets in hash mode")
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> index c16b462ddedf..ab2717012b79 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> @@ -88,9 +88,13 @@ static int mlx5_lag_create_port_sel_table(struct mlx5_lag *ldev,
>  								      &dest, 1);
>  			if (IS_ERR(lag_definer->rules[idx])) {
>  				err = PTR_ERR(lag_definer->rules[idx]);
> -				while (i--)
> -					while (j--)
> +				do {
> +					while (j--) {
> +						idx = i * ldev->buckets + j;
>  						mlx5_del_flow_rules(lag_definer->rules[idx]);
> +					}
> +					j = ldev->buckets;
> +				} while (i--);

So, before the code was:

while (i--)
    while (j--)
        mlx5_del_flow_rules(lag_definer->rules[idx]);

That just calls mlx5_del_flow_rules a bunch of times but keeps using the
wrong index, which is obviously wrong.

The new fix is to calculate the index properly (hence the switch to a do
{ } while (0) loop, so that we properly delete all of the older rules
rather than calling mlx5_del_flow_rules multiple times on the wrong index.

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  				goto destroy_fg;
>  			}
>  		}