[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202406040854.fSEvlFam-lkp@intel.com>
Date: Tue, 4 Jun 2024 08:46:28 +0800
From: kernel test robot <lkp@...el.com>
To: Andreas Kemnade <andreas@...nade.info>, marcel@...tmann.org,
luiz.dentz@...il.com, johan@...nel.org, gregkh@...uxfoundation.org,
jirislaby@...nel.org, pmenzel@...gen.mpg.de,
linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
Adam Ford <aford173@...il.com>, Tony Lindgren <tony@...mide.com>,
tomi.valkeinen@...asonboard.com,
Péter Ujfalusi <peter.ujfalusi@...il.com>,
robh@...nel.org, hns@...delico.com
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v3 3/4] gnss: Add driver for AI2 protocol
Hi Andreas,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.10-rc2 next-20240603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/gnss-Add-AI2-protocol-used-by-some-TI-combo-chips/20240603-224753
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20240603144400.2195564-4-andreas%40kemnade.info
patch subject: [PATCH v3 3/4] gnss: Add driver for AI2 protocol
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240604/202406040854.fSEvlFam-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406040854.fSEvlFam-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406040854.fSEvlFam-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gnss/ai2.c: In function 'process_ai2_frame':
>> drivers/gnss/ai2.c:340:13: error: implicit declaration of function 'get_unaligned_le16' [-Werror=implicit-function-declaration]
340 | if (get_unaligned_le16(data + i) != sum) {
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/get_unaligned_le16 +340 drivers/gnss/ai2.c
324
325 /* do some sanity checks and split frame into packets */
326 static void process_ai2_frame(struct ai2_device *ai2dev)
327 {
328 u16 sum;
329 int i;
330 u8 *head;
331 u8 *data;
332
333 sum = 0;
334 data = ai2dev->recv_skb->data;
335 for (i = 0; i < ai2dev->recv_skb->len - 2; i++)
336 sum += data[i];
337
338 print_hex_dump_bytes("ai2 frame: ", DUMP_PREFIX_OFFSET, data, ai2dev->recv_skb->len);
339
> 340 if (get_unaligned_le16(data + i) != sum) {
341 dev_dbg(ai2dev->dev,
342 "checksum error in reception, dropping frame\n");
343 return;
344 }
345
346 /* reached if byte 1 in the command packet is set to 1 */
347 if (data[1] == AI2_ACK)
348 return;
349
350 head = skb_pull(ai2dev->recv_skb, 2); /* drop frame start marker */
351 while (head && (ai2dev->recv_skb->len >= 3)) {
352 u8 cmd;
353 u16 pktlen;
354
355 cmd = head[0];
356 pktlen = get_unaligned_le16(head + 1);
357 data = skb_pull(ai2dev->recv_skb, 3);
358 if (!data)
359 break;
360
361 if (pktlen > ai2dev->recv_skb->len)
362 break;
363
364 head = skb_pull(ai2dev->recv_skb, pktlen);
365
366 process_ai2_packet(ai2dev, cmd, data, pktlen);
367 }
368 }
369
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists