linux-kernel - Re: [PATCH] printk: Rename console_replay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl7Lo5eGJKLjbTUc@pathway.suse.cz>
Date: Tue, 4 Jun 2024 10:09:07 +0200
From: Petr Mladek <pmladek@...e.com>
To: Sreenath Vijayan <sreenath.vijayan@...y.com>
Cc: john.ogness@...utronix.de, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, rdunlap@...radead.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	taichi.shimoyashiki@...y.com, daniel.palmer@...y.com,
	anandakumar.balasubramaniam@...y.com
Subject: Re: [PATCH] printk: Rename console_replay_all() and update context

On Fri 2024-05-31 10:49:08, Petr Mladek wrote:
> On Thu 2024-05-30 13:15:47, Sreenath Vijayan wrote:
> > Rename console_replay_all() to console_try_replay_all() to make
> > clear that the implementation is best effort. Also, the function
> > should not be called in NMI context as it takes locks, so update
> > the comment in code.
> > 
> > Fixes: 693f75b91a91 ("printk: Add function to replay kernel log on consoles")
> > Fixes: 1b743485e27f ("tty/sysrq: Replay kernel log messages on consoles via sysrq")
> > Suggested-by: Petr Mladek <pmladek@...e.com>
> > Signed-off-by: Shimoyashiki Taichi <taichi.shimoyashiki@...y.com>
> > Signed-off-by: Sreenath Vijayan <sreenath.vijayan@...y.com>
> 
> Thanks for the fix.
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
 
> PS: I am going to queue it for 6.11. It is not critical
>     to hurry it into 6.10-rcX.

JFYI, the patch has been comitted into printk/linux.git,
branch for-6.11.

BTW:

I have pushed a patch which came to my mailbox with ID

   66582edb.650a0220.8de7.c591SMTPIN_ADDED_BROKEN@...google.com

>From some reasons, it is not available in the official archive
at lore.kernel.org. Instead, I have mentioned in the commit
message

     https://lore.kernel.org/r/Zlguq/wU21Z8MqI4@sreenath.vijayan@sony.com

which points to the same patch (same changes), exists at
lore.kernel.org but I havn't got that one from some reason.

Best Regards,
Petr