linux-kernel - Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874ja9t90t.fsf@kernel.org>
Date: Tue, 04 Jun 2024 11:19:30 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Lu Baolu <baolu.lu@...ux.intel.com>
Cc: Joerg Roedel <joro@...tes.org>,  Will Deacon <will@...nel.org>,  Robin
 Murphy <robin.murphy@....com>,  Jason Gunthorpe <jgg@...pe.ca>,  Kevin
 Tian <kevin.tian@...el.com>,  Yi Liu <yi.l.liu@...el.com>,  David Airlie
 <airlied@...il.com>,  Daniel Vetter <daniel@...ll.ch>,  Bjorn Andersson
 <andersson@...nel.org>,  Mathieu Poirier <mathieu.poirier@...aro.org>,
  Alex Williamson <alex.williamson@...hat.com>,  mst@...hat.com,  Jason
 Wang <jasowang@...hat.com>,  Thierry Reding <thierry.reding@...il.com>,
  Jonathan Hunter <jonathanh@...dia.com>,  Mikko Perttunen
 <mperttunen@...dia.com>,  iommu@...ts.linux.dev,
  dri-devel@...ts.freedesktop.org,  linux-kernel@...r.kernel.org,
    Jeff Johnson <quic_jjohnson@...cinc.com>, ath11k@...ts.infradead.org
Subject: Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc()

Lu Baolu <baolu.lu@...ux.intel.com> writes:

> An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is
> attached to ab_ahb->fw.dev in the same function.
>
> Use iommu_paging_domain_alloc() to make it explicit.
>
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> ---
>  drivers/net/wireless/ath/ath11k/ahb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
> index ca0f17ddebba..a469647719f9 100644
> --- a/drivers/net/wireless/ath/ath11k/ahb.c
> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
> @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab)
>  
>  	ab_ahb->fw.dev = &pdev->dev;
>  
> -	iommu_dom = iommu_domain_alloc(&platform_bus_type);
> -	if (!iommu_dom) {
> +	iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev);
> +	if (IS_ERR(iommu_dom)) {
>  		ath11k_err(ab, "failed to allocate iommu domain\n");
> -		ret = -ENOMEM;
> +		ret = PTR_ERR(iommu_dom);
>  		goto err_unregister;
>  	}

Adding Jeff and ath11k list so that they can review this as well.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches