linux-kernel - Re: [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1c63097-b628-4c97-add6-40fa479a7806@linux.intel.com>
Date: Tue, 4 Jun 2024 10:37:17 +0200
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Johan Hovold <johan+linaro@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc: Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Sanyog Kale <sanyog.r.kale@...el.com>, alsa-devel@...a-project.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message



On 6/4/24 02:52, Johan Hovold wrote:
> Drop the redundant probe debug message which is already provided by
> driver core. Whether probe succeeded can also be determined through
> sysfs.
> 
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  drivers/soundwire/bus_type.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index 43e732ca73c0..5b9b129badff 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -152,8 +152,6 @@ static int sdw_drv_probe(struct device *dev)
>  
>  	mutex_unlock(&slave->sdw_dev_lock);
>  
> -	dev_dbg(dev, "probe complete\n");
> -
>  	return 0;
>  }

I don't see the point of removing this, we've used it for the last 5
years to figure out when the probe complete vs. when the device becomes
attached. It's a simple log that helped us immensely with race
conditions, etc.

And no, sysfs is not a viable alternative to look at CI logs, and
enabling dynamic debug on the driver core would be way to verbose.