linux-kernel - Re: [PATCH v4 2/6] hwmon: Add support for SPD5118 compliant temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 18:48:52 +1000
From: Stephen Horvath <s.horvath@...look.com.au>
To: Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 René Rebe <rene@...ctcode.de>,
 Thomas Weißschuh <linux@...ssschuh.net>,
 Armin Wolf <W_Armin@....de>
Subject: Re: [PATCH v4 2/6] hwmon: Add support for SPD5118 compliant
 temperature sensors

Hi,

On 4/6/24 14:02, Guenter Roeck wrote:
> Add support for SPD5118 (Jedec JESD300) compliant temperature
> sensors. Such sensors are typically found on DDR5 memory modules.
> 
> Cc: René Rebe <rene@...ctcode.de>
> Cc: Thomas Weißschuh <linux@...ssschuh.net>
> Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>
> Tested-by: Thomas Weißschuh <linux@...ssschuh.net>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v4: No change
> 
> v3: Shorten JESD300-5B.01 to JESD300; 5B.01 refers to the version
>      of the standard
>      Drop unnecessary 'attr' parameter from spd5118_{read,write}_enable()
> 
> v2: Drop PEC property documentation
>      Add note indicating that alarm attributes are sticky until read
>      to documentation
>      Fix detect function
>      Fix misspelling in Makefile (CONFIG_SENSORS_SPD5118->CONFIG_SENSORS_SPD5118)
> 
>   Documentation/hwmon/index.rst   |   1 +
>   Documentation/hwmon/spd5118.rst |  55 ++++
>   drivers/hwmon/Kconfig           |  12 +
>   drivers/hwmon/Makefile          |   1 +
>   drivers/hwmon/spd5118.c         | 481 ++++++++++++++++++++++++++++++++
>   5 files changed, 550 insertions(+)
>   create mode 100644 Documentation/hwmon/spd5118.rst
>   create mode 100644 drivers/hwmon/spd5118.c
> 

It seems to report correct temperatures for my sticks, so I guess:

Tested-by: Stephen Horvath <s.horvath@...look.com.au>

Thanks,
Steve