[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1483c59d26174defb6fb0886a7375ef0@realtek.com>
Date: Tue, 4 Jun 2024 08:57:44 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Kalle Valo <kvalo@...nel.org>
CC: Wolfram Sang <wsa+renesas@...g-engineering.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: RE: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with wait_for_completion_timeout()
Kalle Valo <kvalo@...nel.org> wrote:
> Ping-Ke Shih <pkshih@...ltek.com> writes:
>
> > Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:
> >> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> >> store the result of wait_for_completion_timeout() causing patterns like:
> >>
> >> timeout = wait_for_completion_timeout(...)
> >> if (!timeout) return -ETIMEDOUT;
> >>
> >> with all kinds of permutations. Use 'time_left' as a variable to make the code
> >> self explaining.
> >>
> >> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> >
> > Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
>
> BTW Ping, you can also take it directly to your tree if you want. But if you
> want me to take the patch, then please assign it to me on patchwork (ie.
> change 'Delegate to' to 'kvalo'). My preference is to take it to your
> tree, smaller risk of concflicts that way, but up to you.
I will take it to my tree.
Ping-Ke
Powered by blists - more mailing lists