linux-kernel - Re: [PATCH v6 07/11] iomap: fix iomap_dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240604094331.gybm6la3xdunpcin@quentin>
Date: Tue, 4 Jun 2024 09:43:31 +0000
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: Dave Chinner <david@...morbit.com>
Cc: chandan.babu@...cle.com, akpm@...ux-foundation.org, brauner@...nel.org,
	willy@...radead.org, djwong@...nel.org,
	linux-kernel@...r.kernel.org, hare@...e.de, john.g.garry@...cle.com,
	gost.dev@...sung.com, yang@...amperecomputing.com,
	p.raghav@...sung.com, cl@...amperecomputing.com,
	linux-xfs@...r.kernel.org, hch@....de, mcgrof@...nel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v6 07/11] iomap: fix iomap_dio_zero() for fs bs > system
 page size

> >  static int __init iomap_init(void)
> >  {
> > +	zero_fs_block = alloc_pages(GFP_KERNEL | __GFP_ZERO, ZERO_FSB_ORDER);
> > +	if (!zero_fs_block)
> > +		return -ENOMEM;
> > +
> >  	return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE),
> >  			   offsetof(struct iomap_ioend, io_bio),
> >  			   BIOSET_NEED_BVECS);
> 
> just create an iomap_dio_init() function in iomap/direct-io.c
> and call that from here. Then everything can be private to
> iomap/direct-io.c...

 Sounds good :)