[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <961fa617-a76b-4b79-956b-795a55fec959@gmail.com>
Date: Tue, 4 Jun 2024 11:44:01 +0100
From: Mudit Sharma <muditsharma.info@...il.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
ivan.orlov0322@...il.com, jic23@...nel.org, lars@...afoo.de,
krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v2 3/3] MAINTAINERS: Add maintainer for ROHM BH1745
On 03/06/2024 23:37, Javier Carrasco wrote:
> On 03/06/2024 18:21, Mudit Sharma wrote:
>> Add myself as maintainer for ROHM BH1745 colour sensor driver.
>>
>> Signed-off-by: Mudit Sharma <muditsharma.info@...il.com>
>> ---
>> v1->v2:
>> - No changes
>>
>> MAINTAINERS | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d6c90161c7bf..945873321fef 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -19407,6 +19407,13 @@ S: Supported
>> F: drivers/power/supply/bd99954-charger.c
>> F: drivers/power/supply/bd99954-charger.h
>>
>> +ROHM BH1745 COLOUR SENSOR
>> +M: Mudit Sharma <muditsharma.info@...il.com>
>> +L: linux-iio@...r.kernel.org
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml
>> +F: drivers/iio/light/bh1745.c
>> +
>> ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER
>> M: Tomasz Duszynski <tduszyns@...il.com>
>> S: Maintained
>
> Hi Mudit,
>
> is there any special reason to have a separate patch for this? The
> addition to MAINTANERS for new drives is usually included in the patch
> that provides the driver itself.
>
> Best regards,
> Javier Carrasco
Hi Javier,
Adding this in a separate commit was just a pattern I notices with some
other drivers, for instance 3b4e0e9.
If necessary and/or considered good practice, I can squash this in the
patch that brings in the driver.
Best regards,
Mudit Sharma
Powered by blists - more mailing lists