linux-kernel - Re: [PATCH] [v3] HID: intel-ish-hid: fix endian-conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ade5ed726ad79a3111f90370eac670c3cb1c7161.camel@linux.intel.com>
Date: Tue, 04 Jun 2024 04:23:15 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: "Zhang, Lixu" <lixu.zhang@...el.com>, Arnd Bergmann <arnd@...nel.org>, 
	Jiri Kosina <jikos@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Benjamin Tissoires <bentiss@...nel.org>, 
	"linux-input@...r.kernel.org"
	 <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v3] HID: intel-ish-hid: fix endian-conversion

On Mon, 2024-06-03 at 08:38 +0000, Zhang, Lixu wrote:
> > -----Original Message-----
> > From: Arnd Bergmann <arnd@...nel.org>
> > Sent: Monday, June 3, 2024 3:41 PM
> > To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>; Jiri
> > Kosina
> > <jikos@...nel.org>; Zhang, Lixu <lixu.zhang@...el.com>
> > Cc: Arnd Bergmann <arnd@...db.de>; Benjamin Tissoires
> > <bentiss@...nel.org>; linux-input@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: [PATCH] [v3] HID: intel-ish-hid: fix endian-conversion
> > 
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > The newly added file causes a ton of sparse warnings about the
> > incorrect use of
> > __le32 and similar types:
> > 
> > Add the necessary conversions and use temporary variables where
> > appropriate
> > to avoid converting back.
> > 
> > Fixes: 579a267e4617 ("HID: intel-ish-hid: Implement loading
> > firmware from
> > host feature")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Zhang Lixu <lixu.zhang@...el.com>
> Tested-by: Zhang Lixu <lixu.zhang@...el.com>

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> 
> Thanks,
> Lixu
> > ---