linux-kernel - Re: [PATCH v6 00/15] Fast kernel headers: split linux/mm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKPOu+8R_KUudoNNGM5m2q6oS0oGY3Hyc_7bKM+-DtFFjJicsg@mail.gmail.com>
Date: Tue, 4 Jun 2024 15:22:57 +0200
From: Max Kellermann <max.kellermann@...os.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, sfr@...b.auug.org.au, david@...hat.com
Subject: Re: [PATCH v6 00/15] Fast kernel headers: split linux/mm.h

On Tue, Jun 4, 2024 at 3:02 PM Matthew Wilcox <willy@...radead.org> wrote:
> I am not a fan of these patches.  They will make it harder to work on
> the MM system.  We briefly discussed them at LSFMM and nobody was in
> favour of them.  I'm afraid you're shouting into the wind.

Thanks for letting me know, but I'm confused because similar patches
have been merged pretty often.

For a very weird example, look at commit adeb04362d74 ("kernel.h: Move
upper_*_bits() and lower_*_bits() to wordpart.h") which was submitted
on Feb 14th; and then look at
https://lore.kernel.org/lkml/20240209164027.2582906-34-max.kellermann@ionos.com/
- it's exactly the same patch, but I submitted it 5 days earlier, yet
the other one was merged.

Other recent examples (though without offending earlier patches from me):
- d186eb1ee885 ("cpumask: split out include/linux/cpumask_types.h")
- f7515d9fe8fc4 ("objtool: Add objtool_types.h")
- cb5a065b4ea9 ("headers/deps: mm: Split <linux/gfp_types.h> out of
<linux/gfp.h>")
- 50d91c765825 ("hrtimers: Split out hrtimer_types.h")
- 9983deb26d90 ("Split out irqflags_types.h")
- 6d5e9d636830 ("pid: Split out pid_types.h")
.... and so on ...

If there is a general agreement that nobody is in favor of these
patches, why are they merged when other people submit them?

Max