linux-kernel - Re: [PATCH] io_uring: fix possible deadlock in io_register_iowq_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171750832945.373240.5340875250569409350.b4-ty@kernel.dk>
Date: Tue, 04 Jun 2024 07:38:49 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Hagar Hemdan <hagarhem@...zon.com>
Cc: Maximilian Heyne <mheyne@...zon.de>, 
 Norbert Manthey <nmanthey@...zon.de>, 
 Pavel Begunkov <asml.silence@...il.com>, io-uring@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring: fix possible deadlock in
 io_register_iowq_max_workers()


On Tue, 04 Jun 2024 13:05:27 +0000, Hagar Hemdan wrote:
> The io_register_iowq_max_workers() function calls io_put_sq_data(),
> which acquires the sqd->lock without releasing the uring_lock.
> Similar to the commit 009ad9f0c6ee ("io_uring: drop ctx->uring_lock
> before acquiring sqd->lock"), this can lead to a potential deadlock
> situation.
> 
> To resolve this issue, the uring_lock is released before calling
> io_put_sq_data(), and then it is re-acquired after the function call.
> 
> [...]

Applied, thanks!

[1/1] io_uring: fix possible deadlock in io_register_iowq_max_workers()
      commit: a59035de589f31f195ed1fff97007d332552a72b

Best regards,
-- 
Jens Axboe