linux-kernel - Re: [PATCH v3 2/2] pinctrl: rockchip: add rk3308b SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 17:20:38 +0500
From: Dmitry Yashin <dmt.yashin@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, Heiko Stuebner
 <heiko@...ech.de>, Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Jianqun Xu <jay.xu@...k-chips.com>, Jonas Karlman <jonas@...boo.se>,
 devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Dmitry Yashin <dmt.yashin@...il.com>
Subject: Re: [PATCH v3 2/2] pinctrl: rockchip: add rk3308b SoC support

Hi Dan,

On 6/5/24 12:22 PM, Dan Carpenter wrote:
> On Tue, Jun 04, 2024 at 07:10:20PM +0500, Dmitry Yashin wrote:
> Why does this one have a Fixes tag?  Isn't this new hardware support?
> Possibly patch 1/2 was not actually a fix but just preparation for this
> patch?
>
> regards,
> dan carpenter


Initial pinctrl support for rk3308 included registers for rk3308b variant,
which didn't work well with some pins of the first SoC and these reg's
were fixed in the patch mentioned in the tag. So I added Fixes tag as this
patch brings back proper setup for rk3308b and 1/2 indeed
is the preparation.

Thank you for taking your time on it. Perhaps I should describe such
moments better next time.


(resend without broken new line sorry)

-- 
Thanks,
Dmitry