[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <171759206880.1969597.15358870283165767535.kvalo@kernel.org>
Date: Wed, 5 Jun 2024 12:54:30 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-kernel@...r.kernel.org,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
linux-wireless@...r.kernel.org
Subject: Re: [PATCH 3/6] wifi: mac80211: use 'time_left' variable with
wait_for_completion_timeout()
Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
The title should be:
wifi: mwl8k: use 'time_left' variable with wait_for_completion_timeout()
I can fix that, no need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240603091541.8367-4-wsa+renesas@sang-engineering.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists