linux-kernel - Re: [PATCH v6 0/3] arm64: dts: add i.MX95 and EVK board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 05 Jun 2024 07:11:45 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Conor Dooley <conor+dt@...nel.org>, 
 linux-arm-kernel@...ts.infradead.org, 
 Alexander Stein <alexander.stein@...tq-group.com>, 
 Peng Fan <peng.fan@....com>, Fabio Estevam <festevam@...il.com>, 
 linux-kernel@...r.kernel.org, Sascha Hauer <s.hauer@...gutronix.de>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, 
 Conor Dooley <conor.dooley@...rochip.com>, imx@...ts.linux.dev, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 0/3] arm64: dts: add i.MX95 and EVK board


On Wed, 05 Jun 2024 09:22:47 +0800, Peng Fan (OSS) wrote:
> Add a minimal i.MX95 dtsi and EVK board dts.
> i.MX95 has a M33 running SCMI firmware that supports
> pinctrl/power/perf/clock and etc.
> 
> imx95-pinfunc.h will trigger checkpatch error, that is expected and same
> as other i.MX platforms.
> 
> In v6, I added back a dependency on pinctrl, because [1] has got A-b/R-b
> from Maintainers, so it would be soon got merged.
> 
> There will be dtbs_check error before [1] got landed. With [1] merged,
> there will be no dtbs_check error.
> 
> [1] https://lore.kernel.org/all/20240521-pinctrl-scmi-imx95-v1-0-9a1175d735fd@nxp.com/
> 
> This patchset is just a minimal support for i.MX95. After this patchset
> is accepted, a following patchset will include more nodes and features.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> Changes in v6:
> - Add pinctrl nodes and pin settings
> - Add imx95-pinfunc.h
> - Drop fsl,cd-gpio-disable-wakeup which is downstream property
> - Per i.MX M33 SCMI firmware, drop unused PERF entries in imx95-power.h
> - Rebased to next-20240604
> - Link to v5: https://lore.kernel.org/r/20240506-imx95-dts-v3-v5-0-5ec9b99cfb2f@nxp.com
> 
> Changes in v5:
> - Drop unused regulator and alias for now.
> - Fix CHECK_DTB warning.
> - Link to v4: https://lore.kernel.org/r/20240503-imx95-dts-v3-v4-0-535ddc2bde73@nxp.com
> 
> Changes in v4:
> - Sort nodes by address
> - Drop coresight nodes
> - Align clock rates for SDHC1-3
> - Drop wdog3 board specific property
> - Link to v3: https://lore.kernel.org/r/20240428-imx95-dts-v3-v3-0-765395f88b9f@nxp.com
> 
> Changes in v3:
> - Drop irqsteer node because binding not accepted
> - Pass dtbs_check
> - Link to v2: https://lore.kernel.org/r/20240226-imx95-dts-v2-0-00e36637b07e@nxp.com
> 
> Changes in v2:
> - Addressed Rob and Krzysztof's comments, and fix dts_check issue
>   To pass the dtbs_check, need apply:
>   https://lore.kernel.org/all/20240226070910.3379108-1-peng.fan@oss.nxp.com/
>   https://lore.kernel.org/all/20240226130243.3820915-1-peng.fan@oss.nxp.com/
>   https://lore.kernel.org/all/20240226130516.3821803-1-peng.fan@oss.nxp.com/
>   https://lore.kernel.org/all/20240226130826.3824251-1-peng.fan@oss.nxp.com/
>   https://lore.kernel.org/all/20240219-imx-mailbox-v8-1-75535a87794e@nxp.com/
> 
> - Link to v1: https://lore.kernel.org/r/20240218-imx95-dts-v1-0-2959f89f2018@nxp.com
> 
> ---
> Peng Fan (3):
>       dt-bindings: arm: fsl: add i.MX95 19x19 EVK board
>       arm64: dts: freescale: add i.MX95 basic dtsi
>       arm64: dts: freescale: add i.MX95 19x19 EVK minimal board dts
> 
>  Documentation/devicetree/bindings/arm/fsl.yaml    |    6 +
>  arch/arm64/boot/dts/freescale/Makefile            |    1 +
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts |  200 ++++
>  arch/arm64/boot/dts/freescale/imx95-clock.h       |  187 ++++
>  arch/arm64/boot/dts/freescale/imx95-pinfunc.h     |  865 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx95-power.h       |   47 +
>  arch/arm64/boot/dts/freescale/imx95.dtsi          | 1063 +++++++++++++++++++++
>  7 files changed, 2369 insertions(+)
> ---
> base-commit: a1bede4830147a5a29ea6443724837ee0b126fd9
> change-id: 20240428-imx95-dts-v3-bee59f0e559b
> 
> Best regards,
> --
> Peng Fan <peng.fan@....com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx95-19x19-evk.dtb' for 20240605-imx95-dts-v3-v6-0-2ce275ed0e80@....com:

arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: scmi: protocol@19: Unevaluated properties are not allowed ('regusdhc2vmmcgrp', 'uart1grp', 'usdhc1-100mhzgrp', 'usdhc1-200mhzgrp', 'usdhc1grp', 'usdhc2-100mhzgrp', 'usdhc2-200mhzgrp', 'usdhc2gpiogrp', 'usdhc2grp' were unexpected)
	from schema $id: http://devicetree.org/schemas/firmware/arm,scmi.yaml#