linux-kernel - Re: [PATCH] livepatch: introduce klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <92FCCE66-8CE5-47B4-A20C-31DC16EE3DE0@gmail.com>
Date: Wed, 5 Jun 2024 10:38:30 +0800
From: zhang warden <zhangwarden@...il.com>
To: Joe Lawrence <joe.lawrence@...hat.com>
Cc: Miroslav Benes <mbenes@...e.cz>,
 Josh Poimboeuf <jpoimboe@...nel.org>,
 Jiri Kosina <jikos@...nel.org>,
 Petr Mladek <pmladek@...e.com>,
 live-patching@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: introduce klp_func called interface

Hi Joe,

> 
> Perhaps "responsibility" is a better description.  This would introduce
> an attribute that someone's userspace utility is relying on.  It should
> at least have a kselftest to ensure a random patch in 2027 doesn't break
> it.
I sent this patch to see the what the community thinks about this attribute (although it think it is necessary and this will be more convenient for users).

If this patch is seems to be good, I will add a kselftest to this attribute.

As Miroslav and Petr said, keeping klp_ftrace_handler() as fast as possible is also important, which I need to find a way to keep it fast (or just setting the state to be true instead of a judgement?).

> The kernel docs provide a lot of explanation of the complete ftracing
> interface.  It's pretty power stuff, though you may also go the other
> direction and look into using the trace-cmd front end to simplify all of
> the sysfs manipulation.  Julia Evans wrote a blog [1] a while back that
> provides a some more examples.
> 
> [1] https://jvns.ca/blog/2017/03/19/getting-started-with-ftrace/
> 
> --
> Joe

Nice of you! Thanks! I will learn it!

Regards,
Wardenjohn