linux-kernel - RE: pwm: Fix double shift bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240605144305.78002-1-iivanov@suse.de>
Date: Wed,  5 Jun 2024 17:43:05 +0300
From: "Ivan T. Ivanov" <iivanov@...e.de>
To: gregkh@...uxfoundation.org
Cc: cve@...nel.org,
	linux-cve-announce@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: RE: pwm: Fix double shift bug

Hi,

I could argue that this is not CVE at all. It changes just bit positions.

-	PWMF_REQUESTED = 1 << 0,
-	PWMF_EXPORTED = 1 << 1,
+	PWMF_REQUESTED = 0,
+	PWMF_EXPORTED = 1,

ie. before fix they 1 and 2 and after the fix 0, 1.

All call sites are using set/test_bit() on unsigned long flags.

Yes, double shift do not look right, but I don't see how
this could lead to malfunction, let alone a CVE.

Regards,
Ivan