lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <dbqrrkkitwhvmcpgcpapdw7a7zjgdkidr4cyyjxyr7mwiihygo@pqzstp2nl7zg>
Date: Wed, 5 Jun 2024 10:52:53 -0400
From: Kenton Groombridge <concord@...too.org>
To: Johannes Berg <johannes@...solutions.net>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, 
	Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH v2] wifi: mac80211: Avoid address calculations via out of
 bounds array indexing

On 24/06/04 09:29PM, Johannes Berg wrote:
> Looking at your patch again, this seems wrong?
> 
> > +				local->hw_scan_req->req.channels[*n_chans++] =
> >  							req->channels[i];
> > 
> 
> This will increment n_chans rather than *n_chans, no?
> 

Ah ha! A silly mistake that I missed. V3 to follow soon.

-- 
Kenton Groombridge
Gentoo Linux Developer, SELinux Project

Download attachment "signature.asc" of type "application/pgp-signature" (964 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ