linux-kernel - Re: [PATCH v7 08/10] KVM VMX: Move MSR_IA32_VMX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmCGXhnlwQjqbfab@google.com>
Date: Wed, 5 Jun 2024 08:38:06 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Xiaoyao Li <xiaoyao.li@...el.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Kai Huang <kai.huang@...el.com>, Shan Kang <shan.kang@...el.com>, Xin Li <xin3.li@...el.com>, 
	Zhao Liu <zhao1.liu@...el.com>
Subject: Re: [PATCH v7 08/10] KVM VMX: Move MSR_IA32_VMX_MISC bit defines to asm/vmx.h

On Wed, May 22, 2024, Xiaoyao Li wrote:
> On 5/21/2024 1:59 AM, Sean Christopherson wrote:
> > +#define VMX_MISC_ACTIVITY_SHUTDOWN		BIT_ULL(7)
> 
> Same as Patch 4. It is newly added but will be used by following patch 10.
> 
> Call out it in change log or move it to patch 10.

This one actually is mentioned, though it's not super obvious.

    Opportunistically use BIT_ULL() instead of open coding hex values, add
    defines for feature bits that are architecturally defined, and move the
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    defines down in the file so that they are colocated with the helpers for
    getting fields from VMX_MISC.