linux-kernel - Re: [PATCH] drm/xe/vm: Simplify if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmCUN0bb/d2NnftV@DUT025-TGLU.fm.intel.com>
Date: Wed, 5 Jun 2024 16:37:11 +0000
From: Matthew Brost <matthew.brost@...el.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
CC: <lucas.demarchi@...el.com>, <ogabbay@...nel.org>,
	<thomas.hellstrom@...ux.intel.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
	<daniel@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/xe/vm: Simplify if condition

On Tue, Jun 04, 2024 at 06:06:22PM +0000, Matthew Brost wrote:
> On Mon, Jun 03, 2024 at 08:00:07PM +0200, Thorsten Blum wrote:
> > The if condition !A || A && B can be simplified to !A || B.
> > 
> > Fixes the following Coccinelle/coccicheck warning reported by
> > excluded_middle.cocci:
> > 
> > 	WARNING !A || A && B is equivalent to !A || B
> > 
> > Compile-tested only.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> 
> Reviewed-by: Matthew Brost <matthew.brost@...el.com>
> 
> Will get this merged once our CI system is working.
> 

Applied to drm-xe-next. Thanks for patch.

Matt

> > ---
> >  drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index 4aa3943e6f29..3137cbbaabde 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -85,8 +85,8 @@ static bool preempt_fences_waiting(struct xe_vm *vm)
> >  
> >  	list_for_each_entry(q, &vm->preempt.exec_queues, compute.link) {
> >  		if (!q->compute.pfence ||
> > -		    (q->compute.pfence && test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> > -						   &q->compute.pfence->flags))) {
> > +		    test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> > +			     &q->compute.pfence->flags)) {
> >  			return true;
> >  		}
> >  	}
> > -- 
> > 2.39.2
> >